CheckDriveSize - some thresholds not taken into account

[Tontonitch]

Hi,

Apparently, the critical thresholds (MaxCrit, MaxCritUsed?, MinCritFree?) are not all taken into account, even in the check result or in the performance data. Only the first threshold is considered.

I've tested a bit with the client v0.3.7 and v0.3.8

v0.3.7

./check_nrpe -H DotNet?-Int1 -c CheckDriveSize -a "MaxWarnUsed?=1% MaxCritUsed?=2% FilterType?=FIXED FilterType?=REMOTE ShowAll" WARNING: C:\: Total: 15G - Used: 5.45G (36%) - Free: 9.54G (64%) > warning, F:\: Total: 20G - Used: 2.27G (11%) - Free: 17.7G (89%) > warning|'C:\'=5848039424B;0;0; 'F:\'=2436673536B;0;0;

./check_nrpe -H DotNet?-Int1 -c CheckDriveSize -a "MaxCritUsed?=2% MaxWarnUsed?=1% FilterType?=FIXED FilterType?=REMOTE ShowAll" CRITICAL: C:\: Total: 15G - Used: 5.45G (36%) - Free: 9.54G (64%) > critical, F:\: Total: 20G - Used: 2.27G (11%) - Free: 17.7G (89%) > critical|'C:\'=36%;0;2; 'F:\'=11%;0;2;

v0.3.8

./check_nrpe -H XP805 -c CheckDriveSize -a "MaxWarnUsed?=1% MaxCritUsed?=2% FilterType?=FIXED FilterType?=REMOTE ShowAll" WARNING: C:\: Total: 57.2G - Used: 42G (73%) - Free: 15.2G (27%) > warning, D:\: Total: 17.4G - Used: 16.3G (93%) - Free: 1.09G (7%) > warning|'C:\ %'=73%;1;0; 'C:\'=45113700352B;613934571;0;0;61393457152; 'D:\ %'=93%;1;0; 'D:\'=17461424128B;186302259;0;0;18630225920;

./check_nrpe -H XP805 -c CheckDriveSize -a "MaxCritUsed?=2% MaxWarnUsed?=1% FilterType?=FIXED FilterType?=REMOTE ShowAll" CRITICAL: C:\: Total: 57.2G - Used: 42G (73%) - Free: 15.2G (27%) > critical, D:\: Total: 17.4G - Used: 16.3G (93%) - Free: 1.09G (7%) > critical|'C:\ %'=73%;0;2; 'C:\'=45113700352B;0;1227869143;0;61393457152; 'D:\ %'=93%;0;2; 'D:\'=17461424128B;0;372604518;0;18630225920;

BR,

Yannick

[Tontonitch]

Horrible mistake: I've used the quotes before/after the arguments!

Tested without quotes, it works well (at least for v0.3.7)